feat: implement Format for SmallVec - #472
Merged
Merged
Conversation
Collaborator
Author
|
note: do not merge this before #458 due to possible merge conflicts |
jdm
approved these changes
Aug 30, 2026
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
alejandro-vaz
added a commit
to alejandro-vaz/rust-smallvec
that referenced
this pull request
Aug 30, 2026
* feat: added defmt for smallvec * fix: ran formatter * refactor: removed API boundary * fix: ran formatter * fix: renamed imports to avoid namespace conflicts * refactor: simplified format for smallvec * fix: style formatting * fix: imports --------- Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
alejandro-vaz
added a commit
to alejandro-vaz/rust-smallvec
that referenced
this pull request
Aug 30, 2026
* fix: cargo warnings * Turn all tests into integration tests (servo#495) * Implement arbitrary::Arbitrary for SmallVec (servo#496) Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>` API, gated behind a new optional `arbitrary` feature. Delegates to `Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via the existing `FromIterator` impl. Adds a feature-gated test. Closes servo#494 Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com> * docs: told agents to link to servo contributing guidelines (servo#504) * fix: added since and note for deprecations (servo#488) * style: updated `rustfmt.toml` guidelines (servo#490) * fix: refined style * refactor: new style * fix: style * revert: fn single line * Turn all tests into integration tests (servo#495) * Implement arbitrary::Arbitrary for SmallVec (servo#496) Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>` API, gated behind a new optional `arbitrary` feature. Delegates to `Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via the existing `FromIterator` impl. Adds a feature-gated test. Closes servo#494 Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com> * docs: told agents to link to servo contributing guidelines (servo#504) * fix: added since and note for deprecations (servo#488) * refactor: new style * revert: fn single line * fix: import errors solved * fix: formatting * fix: style again --------- Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com> Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com> Co-authored-by: Tobias Decking <Tobias.Decking@gmail.com> Co-authored-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com> * feat: added borsh serialize (servo#486) * feat: added borsh serialize * fix: formatting * fix: style formatting --------- Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com> * feat: implement `Format` for `SmallVec` (servo#472) * feat: added defmt for smallvec * fix: ran formatter * refactor: removed API boundary * fix: ran formatter * fix: renamed imports to avoid namespace conflicts * refactor: simplified format for smallvec * fix: style formatting * fix: imports --------- Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com> * fix: cargo warnings --------- Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com> Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com> Co-authored-by: Tobias Decking <Tobias.Decking@gmail.com> Co-authored-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR implements
defmt::FormatforSmallVecit does not implement the trait for its iterators
it is locked behind the feature gate "defmt"
this is the initial implementation of it, thus it won't close issue #389, it still lacks:
note: it's not written on its own file as #427 moves towards because it is not an API boundary. it is not only the smallvec type that will implement
Format, but alsoDrain,ExtractIf, etc => it is simply one feature-gated implementation on the typescloses #391
closes #473